Filter crit per react family database py3#382
Closed
ajocher wants to merge 2 commits into
Closed
Conversation
Contributor
Author
|
This document shows the Arrhenius fits per reaction family for the highest rates based on the training reactions in the RMG-database. Some fits show unexpected behavior (several orders of magnitude increasing rates for decreasing temperature). This has to be fixed by for example cleaning up the database and avoiding collision limit violations. Pull request #347 has started this effort. |
Contributor
|
All but one line of this has made it into main, and the remaining change breaks the file format (so I think it is just not going to make it in). Closing for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request comes with the ReactionMechanismGenerator/RMG-Py#1577 pull request. It contains the Arrhenius fits and their generation notebook that are read in by RMG-Py to allow a customized filter criteria per reaction family.