Reduce "error" logging in regression testing (only WARN and above)#2978
Conversation
|
@rwest based on the github actions comment this seems to have worked - ready for review and merge? |
Previously, pysidt, pulled in transitively via rmgpy.data.thermo, would configure a logger at import time, which put all INFO messages into stderr, which would then end up showing as errors in the pull request annotations. Now, only WARNINGs and ERRORs should be reported.
We want WARNINGS and ERRORs to also end up in stderr but INFO should go to stdout so it's in the full CI logs.
|
I hope the last (most recent) commit is the last (final) commit. |
JacksonBurns
left a comment
There was a problem hiding this comment.
LGTM, will wait to see the output though
The way Github renders these `detail` and `summary` blocks is really finickety about blank lines etc. I *think* this will look better in that context.
The INFO information isn't really helpful, and ends up in the annotations. I left the configure_logging method there so it's easy to turn on again if wanted.
Regression Testing Results
Detailed regression test results.Regression test aromatics:Reference: Execution time (DD:HH:MM:SS): 00:00:00:51 aromatics Passed Core Comparison ✅Original model has 15 species. aromatics Passed Edge Comparison ✅Original model has 106 species.
✅ All Observables varied by less than 0.500 on average between old model and new model in all conditions!
aromatics Passed Observable Testing ✅Regression test liquid_oxidation:Reference: Execution time (DD:HH:MM:SS): 00:00:01:53 liquid_oxidation Passed Core Comparison ✅Original model has 37 species. liquid_oxidation Failed Edge Comparison ❌Original model has 214 species. Errors occurred during edge comparison
ERROR conda.cli.main_run:execute(148): `conda run python scripts/checkModels.py liquid_oxidation-edge stable_regression_results/liquid_oxidation/chemkin/chem_edge_annotated.inp stable_regression_results/liquid_oxidation/chemkin/species_edge_dictionary.txt test/regression/liquid_oxidation/chemkin/chem_edge_annotated.inp test/regression/liquid_oxidation/chemkin/species_edge_dictionary.txt` failed. (See above for error)
|
ec0d1bb
into
ReactionMechanismGenerator:main
Motivation or Problem
Previously, pysidt, pulled in transitively via rmgpy.data.thermo, would configure a logger at import time, which put all INFO messages into stderr, which would then end up showing as errors in the pull request annotations.
Description of Changes
Now, only WARNINGs and ERRORs should be reported, to stderr.
The INFO should, however, still go to stdout.
Testing
Let's see if it works (await the Regression testing annotation on this PR)
Other context
I have opened zadorlab/PySIDT#44 on PySIDT