[Documentation]: point users to a specific version of RMG rather than latest#2432
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2432 +/- ##
=======================================
Coverage 48.11% 48.11%
=======================================
Files 110 110
Lines 30625 30625
Branches 7988 7988
=======================================
Hits 14734 14734
Misses 14363 14363
Partials 1528 1528 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Contributor
|
This looks good to me! Only two things: |
JacksonBurns
force-pushed
the
docker_3.1.1
branch
2 times, most recently
from
May 15, 2023 01:54
e8a243d to
c331ad4
Compare
latest should be reserved for development, we will occasionally tag a dev build (maybe monthly) as the most recent latest build
JacksonBurns
force-pushed
the
docker_3.1.1
branch
from
May 15, 2023 02:09
c331ad4 to
95f82cd
Compare
Contributor
|
Gonna force merge this to be in time of tomorrow's RMG Training as well. |
hwpang
approved these changes
May 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR: This PR changes a couple lines in the docs to tell users to download RMG v3.1.1, which is a temporary release we decided on in RMG subgroup to point users toward for RMG training (rather than
latest).Right now the documentation points users towards the
latestbuild, which is the one that is constructed every night and after every merge to main. We should actually point them toward some specific version, which will allow us to actually debug issues since everyone who has problems will be running a version we can try ourselves. The latest build should be used by devs, or in the case that an error has been fixed but a minor or patch release has not yet been published. This should consequently include a more consistent release schedule.To coincide with this I have pushed a 3.1.1 version of RMG to docker. This is not intended for long term use but is instead a stop-gap solution. We already have a PR open for 3.2 #1852 but that will not be done in time for RMG training. This patch release includes all changes from 3.1.0 to today (which will also be in 3.2, and this patch will be deleted).