Rename submodules in rmgpy.tools#1794
Conversation
xiaoruiDong
left a comment
There was a problem hiding this comment.
@mliu49 Thanks for the contribution! I think it is a good idea to standardize the module names. The changes (using all-lowercase names) are according to PEP-8 nomenclature, right? @amarkpayne, your thoughts?
|
This is correct according to PEP-8 (https://www.python.org/dev/peps/pep-0008/#package-and-module-names). I think all of this looks good to go, but should we do the same for the scripts folder? The modules in the script folder are all consistent, but use a different convention. Rebase and I'll approve and merge |
Codecov Report
@@ Coverage Diff @@
## master #1794 +/- ##
==========================================
+ Coverage 42.92% 42.99% +0.06%
==========================================
Files 82 80 -2
Lines 21182 21090 -92
Branches 5519 5513 -6
==========================================
- Hits 9093 9067 -26
+ Misses 11074 11008 -66
Partials 1015 1015
Continue to review full report at Codecov.
|
|
Should be good to go once tests pass. |
|
Thanks for the PR @mliu49 ! |
Motivation or Problem
The submodules in the
toolsmodule are a bit of a mess in terms of naming. The 3.0 release seems like a good opportunity to rename them.Note that RMG-website imports will need to be updated, as will any other dependencies which use the tools module.
Description of Changes
Rename submodules in
rmgpy.toolsand update imports in RMG-Py.Test.Reviewing
Any comments or suggestions about the new names are welcome.