Update file headers and shebangs#1754
Merged
Merged
Conversation
Member
|
Perhaps we'd like to do the same in the -db repo? Current .py files there say |
Contributor
Author
|
Yes, we should also do this for the database repo. It can be included in the (currently non-existent) PR updating scripts to work with Python 3. |
Codecov Report
@@ Coverage Diff @@
## master #1754 +/- ##
======================================
Coverage 32.6% 32.6%
======================================
Files 87 87
Lines 26115 26115
Branches 6875 6875
======================================
Hits 8516 8516
+ Misses 16641 16629 -12
- Partials 958 970 +12
Continue to review full report at Codecov.
|
amarkpayne
previously approved these changes
Oct 9, 2019
amarkpayne
left a comment
Member
There was a problem hiding this comment.
This all looks good to me. If you update this branch I'll merge it tonight. Thanks for the PR @mliu49 !
Change shebang to point to python3 and remove encoding line Ignore __pycache__ directories Update name of Arkane.py script
mliu49
force-pushed
the
update_headers
branch
from
October 10, 2019 12:38
7734aaf to
aa6bfdf
Compare
amarkpayne
approved these changes
Oct 10, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation or Problem
Now that we're using Python 3, the recommended shebang has changed. Since these files are not Python 2 compatible, it is recommended to explicitly refer to
python3in the shebang. Additionally, utf-8 encoding is now default in Python 3, so the encoding line is no longer necessary.While the shebang is technically unnecessary if the file is not intended to be executable, I think it's still useful to keep around to indicate that these are Python 3 files.
Description of Changes
Update the
update_headersfunction inutilities.pyand update all file headers.