Conversation
Codecov Report
@@ Coverage Diff @@
## master #1752 +/- ##
=========================================
Coverage ? 32.61%
=========================================
Files ? 87
Lines ? 26103
Branches ? 6869
=========================================
Hits ? 8514
Misses ? 16619
Partials ? 970Continue to review full report at Codecov.
|
ajocher
approved these changes
Oct 7, 2019
Contributor
|
Thanks for fixing. This looks fine to me and ready to be merged. |
Contributor
Author
|
Thanks! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation or Problem
Exceptions no longer have a message attribute. We fixed a bunch of cases already, but missed some.
Description of Changes
Replace calls to Exception.message with str(Exception).
Testing
These changes fixed the issues I was having. I don't know if it's necessary to do additional testing.