Run database tests in Travis after testing RMG-Py code#1646
Closed
amarkpayne wants to merge 1 commit into
Closed
Conversation
amarkpayne
force-pushed
the
stage_database_tests
branch
2 times, most recently
from
July 1, 2019 16:49
7049762 to
bceec13
Compare
amarkpayne
force-pushed
the
stage_database_tests
branch
from
July 1, 2019 16:50
bceec13 to
227232b
Compare
Member
Author
|
This appears to work as expected, so I'll add it on to the PR. |
Contributor
|
I would suggest running the database tests in parallel with the unit tests instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation or Problem
We are starting to run out of time to complete the database checks if the filter thresholds are to be tested every time as in #1577 . This draft PR explores the idea of running the database test in a separate stage after the unit and functional tests have been run.