Delete simulation files after unit testing#1645
Merged
Merged
Conversation
Member
Author
|
This should pass all of the tests as soon as #1644 is merged |
amarkpayne
force-pushed
the
delete_sim_files
branch
from
June 28, 2019 20:30
9bbfa46 to
b1f47dd
Compare
Codecov Report
@@ Coverage Diff @@
## master #1645 +/- ##
=======================================
Coverage 41.82% 41.82%
=======================================
Files 177 177
Lines 29455 29455
Branches 6059 6059
=======================================
Hits 12319 12319
Misses 16267 16267
Partials 869 869Continue to review full report at Codecov.
|
yunsiechung
approved these changes
Jul 2, 2019
yunsiechung
left a comment
Contributor
There was a problem hiding this comment.
Everything looks good.
It does successfully remove the log and backup log files after unit tests.
Contributor
|
Thanks for catching this. The simulate logs were newly added in #1593. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation or Problem
Whenever the unit test are run, the simulation logs in
rmgpy.tools.simulateTest.pyare created but never deleted (whereas everything else with this test is deleted).Description of Changes
Add statements in
rmgpy.tools.simulateTest.pyto remove the log files after the tests have run.Testing
Ran the unit tests and everything passed and the logs were deleted