Update environment files, including RDKit and Cantera versions#1623
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1623 +/- ##
=======================================
Coverage 41.49% 41.49%
=======================================
Files 176 176
Lines 29314 29314
Branches 6035 6035
=======================================
Hits 12163 12163
- Misses 16298 16299 +1
+ Partials 853 852 -1
Continue to review full report at Codecov.
|
Require newer version of RDKit and add rdkit channel Alphabetize dependencies Remove libgcc and libgfortran (they are included implicitly) Remove scoop
RDKit now generates different SMILES strings for some molecules
cgrambow
approved these changes
Jun 15, 2019
This was referenced Jul 23, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation or Problem
We were artificially limiting our RDKit version, so this removes that limitation.
Description of Changes
Major changes:
Minor changes:
Testing
Haven't done any real testing. Seems like this should be safe as long as all of the tests pass.
Not sure if we want to include this in the release. Comments welcome.