Skip to content

better match base::order(method=) and decreasing=#6655

Merged
MichaelChirico merged 4 commits intomasterfrom
order-args
Jan 6, 2025
Merged

better match base::order(method=) and decreasing=#6655
MichaelChirico merged 4 commits intomasterfrom
order-args

Conversation

@MichaelChirico
Copy link
Copy Markdown
Member

Closes #4456

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.62%. Comparing base (a599557) to head (63fce19).
Report is 14 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6655   +/-   ##
=======================================
  Coverage   98.61%   98.62%           
=======================================
  Files          79       79           
  Lines       14559    14567    +8     
=======================================
+ Hits        14358    14366    +8     
  Misses        201      201           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 11, 2024

Comparison Plot

Generated via commit 63fce19

Download link for the artifact containing the test results: ↓ atime-results.zip

Task Duration
R setup and installing dependencies 4 minutes and 37 seconds
Installing different package versions 7 minutes and 30 seconds
Running and plotting the test cases 2 minutes and 14 seconds

@MichaelChirico
Copy link
Copy Markdown
Member Author

Somehow I'd missed #4458. This PR is narrower, so I suggest merging it independently.

@tdhock
Copy link
Copy Markdown
Member

tdhock commented Jan 6, 2025

lgtm

@MichaelChirico MichaelChirico merged commit ba5773d into master Jan 6, 2025
@MichaelChirico MichaelChirico deleted the order-args branch January 6, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

order optimization does not recognize all order args properly

2 participants