Closed
Conversation
MichaelChirico
commented
Jul 17, 2020
R/onAttach.R
Outdated
| if (!isTRUE(getOption("datatable.quiet"))) { # new option in v1.12.4, #3489 | ||
| packageStartupMessage("data.table ", v, if(dev)paste0(" IN DEVELOPMENT built ",d,g), | ||
| " using ", getDTthreads(verbose=FALSE), " threads (see ?getDTthreads). Latest news: r-datatable.com") | ||
| dev_tag = if (dev) gettextf(" IN DEVELOPMENT built %s%s", d, g, domain="R-data.table") else "" |
Member
Author
There was a problem hiding this comment.
a bit ugly but xgettext ignores the strings passed to ... of gettextf for translation -- even if those strings are gettext themselves. so we have to pull this translation out of the gettextf call for it to work.
ditto below
MichaelChirico
commented
Jul 17, 2020
| msgstr "" | ||
| "Project-Id-Version: data.table 1.12.5\n" | ||
| "POT-Creation-Date: 2020-07-17 14:38\n" | ||
| "Project-Id-Version: data.table 1.12.9\n" |
Member
Author
There was a problem hiding this comment.
strange that this doesn't bump automatically. it seems to do so in the .pot file.
Codecov Report
@@ Coverage Diff @@
## master #4613 +/- ##
=======================================
Coverage 99.61% 99.61%
=======================================
Files 73 73
Lines 14224 14224
=======================================
Hits 14169 14169
Misses 55 55 Continue to review full report at Codecov.
|
added 2 commits
July 18, 2020 10:22
Member
Author
|
Superseded by #5056 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A quick follow up to #4610 (despite the large diff).
Basically trying to address the issue raised in https://bugs.r-project.org/bugzilla/show_bug.cgi?id=17860 by removing non-strings from translation.
Also added some notes for release about bumping the po header version tag.