Conversation
Codecov Report
@@ Coverage Diff @@
## master #3926 +/- ##
======================================
Coverage 99.4% 99.4%
======================================
Files 72 72
Lines 13549 13549
======================================
Hits 13468 13468
Misses 81 81Continue to review full report at Codecov.
|
Member
|
gotta love it when the last issue solves itself! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3669
Working now in dev so just added tests.
Fixed by #3817 on Sep 4th. I tested with the commit before that which failed with the same error reported in dev Jun 27th. I'm not quite sure precisely why #3817 fixes it, or what created the problem in dev before that, but it had changes in the area of evaluating
i, so we'll call it a win.Thanks @franknarf1 for testing dev!