Skip to content

LTO compilation flag, also strict compilation warning check#3878

Merged
mattdowle merged 1 commit intomasterfrom
gcc-err-on-warn-flto
Sep 16, 2019
Merged

LTO compilation flag, also strict compilation warning check#3878
mattdowle merged 1 commit intomasterfrom
gcc-err-on-warn-flto

Conversation

@jangorecki
Copy link
Copy Markdown
Member

follow up of #3864

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 16, 2019

Codecov Report

Merging #3878 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3878   +/-   ##
=======================================
  Coverage   99.42%   99.42%           
=======================================
  Files          72       72           
  Lines       13462    13462           
=======================================
  Hits        13385    13385           
  Misses         77       77

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ba9144...99fc3de. Read the comment docs.

@jangorecki jangorecki added the ci label Sep 16, 2019
@mattdowle mattdowle added this to the 1.12.4 milestone Sep 16, 2019
@mattdowle mattdowle merged commit a888cce into master Sep 16, 2019
@mattdowle mattdowle deleted the gcc-err-on-warn-flto branch September 16, 2019 17:53
@jangorecki
Copy link
Copy Markdown
Member Author

We need to enable that only for data.table, otherwise there is a failure of installation in other packages. Will submit fix soon.

ar: yajl/yajl.o: plugin needed to handle lto object
ar: yajl/yajl_alloc.o: plugin needed to handle lto object
ar: yajl/yajl_buf.o: plugin needed to handle lto object
ar: yajl/yajl_encode.o: plugin needed to handle lto object
ar: yajl/yajl_gen.o: plugin needed to handle lto object
ar: yajl/yajl_lex.o: plugin needed to handle lto object
ar: yajl/yajl_parser.o: plugin needed to handle lto object
ar: yajl/yajl_tree.o: plugin needed to handle lto object
gcc -std=gnu99 -shared -L/usr/lib/R/lib -Wl,-Bsymbolic-functions -Wl,-z,relro -o jsonlite.so base64.o collapse_array.o collapse_object.o collapse_pretty.o escape_chars.o integer64_to_na.o is_datelist.o is_recordlist.o is_scalarlist.o modp_numtoa.o null_to_na.o num_to_char.o parse.o prettify.o push_parser.o r-base64.o register.o row_collapse.o transpose_list.o validate.o -Lyajl -lstatyajl -L/usr/lib/R/lib -lR
installing to /usr/local/lib/R/site-library/00LOCK-jsonlite/00new/jsonlite/libs
** R
** inst
** byte-compile and prepare package for lazy loading
** help
*** installing help indices
** building package indices
** installing vignettes
** testing if installed package can be loaded from temporary location
Error: package or namespace load failed for ‘jsonlite’ in dyn.load(file, DLLpath = DLLpath, ...):
 unable to load shared object '/usr/local/lib/R/site-library/00LOCK-jsonlite/00new/jsonlite/libs/jsonlite.so':
  /usr/local/lib/R/site-library/00LOCK-jsonlite/00new/jsonlite/libs/jsonlite.so: undefined symbol: yajl_gen_array_close
Error: loading failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants