fix: Make non-autoclosing flyouts stay open. #9245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rachel-fenichel
approved these changes
Jul 18, 2025
Collaborator
rachel-fenichel
left a comment
There was a problem hiding this comment.
Thanks for adding tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #9126
Proposed Changes
This PR fixes the behavior for non-autoclosing flyouts. As part of the recent focus changes, flyouts were more or less forced to always autoclose. This is because
Toolbox.clearSelection()winds up callingthis.setSelectedItem(null)->this.updateFlyout(*, null), and the latter unconditionally hides the flyout if the new item isnull. Now, in situations where the toolbox is losing focus, itsautoHidemethod is called, which gates the call toclearSelection()on a check for whether the toolbox's flyout is in autoclose mode. The explicit call toFlyout.autoHideinWorkspaceSvghas been removed because it's redundant as the prior call toautoHide()on the toolbox will wind up invoking it.