fix!: Remove alt+key commands #8961
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rachel-fenichel
approved these changes
May 2, 2025
Collaborator
rachel-fenichel
left a comment
There was a problem hiding this comment.
Change the pr title to fix! to indicate that this is a breaking change for release notes purposes.
a4e6166
into
RaspberryPiFoundation:rc/v12.0.0
10 of 12 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes RaspberryPiFoundation/blockly-keyboard-experimentation#258
Proposed Changes
Remove the alt+key code version of commands
Reason for Changes
Using alt is non-standard and may conflict with window commands, so we're removing it.
Test Coverage
Removed the tests that expect alt to work.
Documentation
Additional Information