fix: Support RTL in WorkspaceSvg.scrollIntoBounds #8936
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gonfunko
approved these changes
Apr 28, 2025
dee27b9
into
RaspberryPiFoundation:rc/v12.0.0
8 of 12 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #8935
Proposed Changes
Add checks for RTL and update the bounds to keep the right or the left in the viewport depending on whether we're in RTL or LTR.
Reason for Changes
Previously, blocks that were too long to fit in the viewport would jump around or always prefer the left side be kept in bounds regardless of RTL.
With the changes, RTL is now handled correctly:
Screen recording 2025-04-28 2.57.15 PM.webm
Screen recording 2025-04-28 2.56.08 PM.webm
Test Coverage
Documentation
Additional Information