feat: expose bringToFront() method
#8472
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Heya @UCYT5040 In the future please comment on an issue before working with on it! Just helps prevent duplicate work from occuring =) |
BeksOmega
approved these changes
Aug 7, 2024
Contributor
BeksOmega
left a comment
There was a problem hiding this comment.
Looks great =) Once this passes CI I'll get it merged!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #8233
Proposed Changes
Removes the
@internalfrom the JSDoc, adds some info about the cost of the function, and also removes an extra colon in the JSDoc.Reason for Changes
Described in the original issue #8233
Test Coverage
Tested manually with browser console in the playground (although I believe the function was working before this, as this change only relates to JSDoc).
Documentation
Yes, documentation for
BlockSvgshould include thebringToFront()method.Additional Information