feat: support dragging comments in the gesture #7977
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5426568 to
76d6f03
Compare
core/gesture.ts
Outdated
| this.dragger.onDrag(e, this.currentDragDeltaXY); | ||
| } | ||
|
|
||
| /** Start dragging the selected bubble. */ |
core/gesture.ts
Outdated
| } | ||
| if (!this.startWorkspace_) { | ||
| throw new Error( | ||
| 'Cannot update dragging the bubble because the start ' + |
core/gesture.ts
Outdated
| handleCommentStart(e: PointerEvent, comment: RenderedWorkspaceComment) { | ||
| if (this.gestureHasStarted) { | ||
| throw Error( | ||
| 'Tried to call gesture.handleBubbleStart, ' + |
Collaborator
There was a problem hiding this comment.
handleBubbleStart -> handleCommentStart
rachel-fenichel
approved these changes
Apr 2, 2024
Collaborator
rachel-fenichel
left a comment
There was a problem hiding this comment.
LGTM after you fix the naming issues in comments and warnings.
johnnesky
pushed a commit
to johnnesky/blockly
that referenced
this pull request
Apr 13, 2024
…#7977) * feat: add dragging of comments in gesture * chore: fix naming problems
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes N/A
Proposed Changes
Makes it so the gesture handles starting drags on comments. The code for starting drags is going to get refactored an unified in a bit, but I wanted to be able to test the comment dragging before then.
Test Coverage
Manually tested, and drags to occur!
Documentation
N/A
Additional Information
N/A