fix!: remove couldConnect parameter from wouldDelete #7968
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
1 task
491843c to
a989f08
Compare
rachel-fenichel
approved these changes
Mar 28, 2024
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes N/A
Proposed Changes
Removes the
couldConnectparameter fromwouldDeletesince that doesn't really make sense in the context of genericIDraggableimplementations.In practice, the only thing this changes is that if you're dragging over the trashcan and the block could connect to something, the block will now be deleted instead of connecting.
Test Coverage
N/A
Documentation
N/A
Additional Information
This is a dupe of #7848
Dependent on #7967
Breaking changes / To fix
If you have implemented a custom delete area that depends on the
couldConnectparameter ofwouldDelete, you should remove references to that parameter.couldConnectis no longer passed toIDeleteAreaobjects because delete areas can now handle objects that have no possibility of connecting (such as workspace comments.