Skip to content

feat: made the method isDragTowardWorkspace non private #7529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
johnnesky merged 7 commits into from
Sep 22, 2023
Merged

feat: made the method isDragTowardWorkspace non private #7529

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2bc3e01
removed internal from horizontal and vertical flyout
Sep 22, 2023
b5fb784
Merge pull request #1 from ramyaram2092/remove-internal-keyword-fromF…
Sep 22, 2023
fd1ddfe
feat : made vertical and horizontal flyout non private
Sep 22, 2023
c9c174e
Merge branch 'osd' of https://github.com/ramyaram2092/blockly into osd
Sep 22, 2023
14a900f
feat : made the method isDragTowardWorkspace non private
Sep 22, 2023
6e6adc2
feat : made the method isDragTowardWorkspace non private
Sep 22, 2023
f40c7e4
feat : made the method isDragTowardWorkspace non-private
Sep 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion core/flyout_horizontal.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,7 +306,6 @@ export class HorizontalFlyout extends Flyout {
* @param currentDragDeltaXY How far the pointer has moved from the position
* at mouse down, in pixel units.
* @returns True if the drag is toward the workspace.
* @internal
*/
override isDragTowardWorkspace(currentDragDeltaXY: Coordinate): boolean {
const dx = currentDragDeltaXY.x;
Expand Down
1 change: 0 additions & 1 deletion core/flyout_vertical.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,7 +274,6 @@ export class VerticalFlyout extends Flyout {
* @param currentDragDeltaXY How far the pointer has moved from the position
* at mouse down, in pixel units.
* @returns True if the drag is toward the workspace.
* @internal
*/
override isDragTowardWorkspace(currentDragDeltaXY: Coordinate): boolean {
const dx = currentDragDeltaXY.x;
Expand Down