fix: do not create extra shadow blocks when mirroring events #7427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #7310
Proposed Changes
If the Create event only has shadow blocks that already exist in the workspace, don't run anything in the event. This is because shadow block handling is done already when a block is disconnected or deleted. These types of events only happen when a block covering a shadow block is moved or deleted.
Behavior Before Change
When mirroring events across a workspace, extra block that has the same data as the shadow block is created.
Behavior After Change
No extra blocks created when mirroring events.
Reason for Changes
bugs
Test Coverage
Documentation
no
Additional Information