feat: merge copy paste work into develop #7379
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: implement basic IPaster interface * feat: add pasters for blocks and workspace comments
* chore: rename CopyData to ICopyData * fix: ICopyable data structures * fix: switch clipboard over to use new copy data interfaces * chore: rename saveInfo to somthing more descriptive
* chore: rename module-local variables to not conflict * feat: make ICopyable generic and update clipboard APIs * chore: switch over more things to use generic ICopyables * chore: fix shortcut items using copy paste * chore: add test for interface between clipboard and pasters * chore: export isCopyable * chore: format * chore: fixup PR comments * chore: add deprecation tags
* fix: add logic for bumping pasted blocks * chore: add tests for bumping pasted blocks to the correct location * fix: add logic for bumping pasted comments * chore: add tests for bumping pasted comments
…ated APIs (#7352) * chore: remove references to clipboard.copy in shortcuts * chore: remove references to clipboard.copy in context menus * chore: fix tests * chore: format * fix: PR comments
maribethb
approved these changes
Aug 11, 2023
| * @param block The block to move to an unambiguous location. | ||
| * @internal | ||
| */ | ||
| export function moveBlockToNotConflict(block: BlockSvg) { |
Contributor
There was a problem hiding this comment.
This was already reviewed in another PR, so this doesn't have to block merging, I'm just curious. does bumpNeighbors not work for this?
This feels like really similar logic to what's happening in bumpNeighbors but you're not taking advantage of some of the methods we already have like we have a connection.neighbours method that takes in a snap radius, etc.
Contributor
Author
There was a problem hiding this comment.
bumpNeighbors always moves whichever block has the inferior connection :/ We want to make sure we're only moving the block that's being pasted.
Wrt code reuse: we're using connection.closest instead of connection.neighbours. They both take in a snap radius and do similar things.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
npm run formatandnpm run lintThe details
Resolves
Fixes N/A
Proposed Changes
Merges the work that was being done on a feature branch into develop.
Reason for Changes
It's better to work off develop if I can so I don't need to worry about changes in develop geting out of sync with changes in my branch.
Additional info
Planning to merge-commit this so that the release notes include info about all of the previous PRs.