fix: Always draw dragged blocks atop others in the workspace. #6874
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Contributor
|
This no longer applies because #6758 was reverted |
1 task
Contributor
BeksOmega
approved these changes
Aug 21, 2023
BeksOmega
reviewed
Aug 21, 2023
Comment on lines
+331
to
+335
| const draggingBlock = this.workspace | ||
| .getCanvas() | ||
| .querySelector('.blocklyDragging'); | ||
| if (draggingBlock) { | ||
| this.workspace.getCanvas().insertBefore(svgRoot, draggingBlock); |
Contributor
There was a problem hiding this comment.
@gonfunko do you remember what case this was handling?
Contributor
Author
There was a problem hiding this comment.
Not offhand :/ Judging by the comment maybe it's when a block is disconnected from a stack?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
npm run formatandnpm run lintThe details
Resolves
Fixes #6852
Proposed Changes
When blocks are dragged, bring them to the front, and update
setParentto insert blocks before the block being dragged, if any, when removing it from its parent.Behavior Before Change
Blocks would occassionally appear behind other blocks when being dragged.
Behavior After Change
Blocks being dragged appear atop all other blocks.
Reason for Changes
Fixes a regression introduced in #6758.