Skip to content

Move delete keyboard shortcut in-progress gesture check to precondition #6274

@BeksOmega

Description

@BeksOmega

🚧⚠️🚧 This issue is being saved for Grace Hopper Open Source Day. 🚧⚠️🚧 An event we're running to help girls and non-binary technologists make their first contributions to open source! Please see our list of help wanted issues if you'd like to contribute!


Describe the bug

The delete keyboard shortcut currently checks if there is a gesture in progress from within its callback function, and returns early if so. This is what the preconditionFn is meant to do. Other keyboard shortcuts check for in-progress gestures from there.

See the relevant code.

To Fix

  1. Add a check to the precondition function to make sure a gesture is not in progress.
  2. Remove the gesture check from the callback.

Metadata

Metadata

Assignees

Labels

ghc-osdReserved for open source day: https://anitab-org.github.io/open-source-day/good first issueissue: bugDescribes why the code or behaviour is wrongsize: smallBugs that can be picked up and completed in 1-3 days

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions