-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Closed
Labels
ghc-osdReserved for open source day: https://anitab-org.github.io/open-source-day/Reserved for open source day: https://anitab-org.github.io/open-source-day/good first issueissue: bugDescribes why the code or behaviour is wrongDescribes why the code or behaviour is wrongsize: smallBugs that can be picked up and completed in 1-3 daysBugs that can be picked up and completed in 1-3 days
Milestone
Description
🚧
Describe the bug
The delete keyboard shortcut currently checks if there is a gesture in progress from within its callback function, and returns early if so. This is what the preconditionFn is meant to do. Other keyboard shortcuts check for in-progress gestures from there.
See the relevant code.
To Fix
- Add a check to the precondition function to make sure a gesture is not in progress.
- Remove the gesture check from the callback.
HollowMan6
Metadata
Metadata
Assignees
Labels
ghc-osdReserved for open source day: https://anitab-org.github.io/open-source-day/Reserved for open source day: https://anitab-org.github.io/open-source-day/good first issueissue: bugDescribes why the code or behaviour is wrongDescribes why the code or behaviour is wrongsize: smallBugs that can be picked up and completed in 1-3 daysBugs that can be picked up and completed in 1-3 days