Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses an unsafe runpath issue created by AMD OpenMP linking that prevents packaging in RHEL 10. The fix involves modifying the CMake configuration to use OpenMP libraries directly instead of the OpenMP target, and setting an explicit RPATH to avoid relative path references.
- Replaced
OpenMP::OpenMP_CXXtarget with${OpenMP_CXX_LIBRARIES}to avoid unsafe runpath generation - Added explicit RPATH configuration using
$ORIGINreferences - Commented out the OpenMP CXX flags setting
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
nunnikri
approved these changes
Aug 19, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #371 +/- ##
===========================================
- Coverage 80.82% 80.81% -0.00%
===========================================
Files 272 272
Lines 20915 20915
===========================================
- Hits 16903 16902 -1
- Misses 4012 4013 +1 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
OpenMP link creates an unsafe runpath -- temp fix for mainline till the issue is resolved with OpenMP -- enable rocAL on RHEL 10
Technical Details
Linking AMD OpenMP to any downstream application creates a runpath which has relative path
Problem
Relative runpaths are deemed unsafe and fails packaging in RHEL 10 or newer
Fix for a similar issue in LLVM / AMD LLVM
llvm/llvm-project#143792
Reproduce issue using AMD OpenMP sample
https://rocm.docs.amd.com/projects/llvm-project/en/latest/conceptual/openmp.html#ompt-target-support
Output
Test Plan
Build in RHEL 10
Test Result
rocAL Package created using RPM
Submission Checklist