madengine v2: ROCm path override + RPD e2e dependency fix#76
Merged
coketaste merged 4 commits intocoketaste/refactor-disfrom Mar 1, 2026
Merged
madengine v2: ROCm path override + RPD e2e dependency fix#76coketaste merged 4 commits intocoketaste/refactor-disfrom
coketaste merged 4 commits intocoketaste/refactor-disfrom
Conversation
ROCM_PATH / --rocm-path: - Add get_rocm_path() and wire through Context, ROCmToolManager, gpu_tool_factory, gpu_validator, container_runner, run orchestrator; add --rocm-path to run CLI - Unit tests for get_rocm_path, Context, ROCmToolManager, run --help; update fixtures and test_get_cached_managers for (vendor, rocm_path) cache RPD e2e: - pre_scripts/trace.sh: install nlohmann-json3-dev (Ubuntu) and json-devel (CentOS) so rocmProfileData rpd_tracer build finds nlohmann/json.hpp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(madengine): ROCm path override + RPD e2e dependency fix
and run orchestrator use configurable rocm_path
run --help; fixtures use get_rocm_path() for AMD detection; integration
test_get_cached_managers updated for (vendor, rocm_path) cache keys
(CentOS) in trace.sh so rpd_tracer builds in container