merge aomp-dev into amd-staging#2336
Closed
z1-cciauto wants to merge 6 commits into
Closed
Conversation
…symbols Strengthen both device-coverage drain tests so a pass actually proves the HSA drain collected device data (the previous checks only confirmed a symbol was present, and the per-test stdout is discarded by check_smoke_dev.sh). HipDevCov now: * requires the HSA drain's uniquely-named profraw (*.hsa<N>.*.profraw), * asserts mod_kernel (hipModuleLoad'd, no host shadow) AND host_kernel are present with nonzero function counts. OmpDevCov now asserts the device function classify has nonzero counts on BOTH branches of its data-dependent if/else (real device PGO data), in addition to the device profraw and the -fprofile-use round trip. Both dump the merged profile to devcov-profile.txt (archived with results) and leave a DEVCOV-SKIPPED.txt marker when a toolchain genuinely lacks the device profile runtime, so a skip is visible rather than a silent pass. Replaces the FileCheck symbol-presence checks (check.txt removed). Co-authored-by: Cursor <cursoragent@cursor.com>
[smoke-dev] HipDevCov/OmpDevCov: assert real device counts, not just symbols
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.