feat(observability): add NVTX tracing and Prometheus metrics#242
Draft
BruceLoveDecimal wants to merge 1 commit into
Draft
feat(observability): add NVTX tracing and Prometheus metrics#242BruceLoveDecimal wants to merge 1 commit into
BruceLoveDecimal wants to merge 1 commit into
Conversation
Signed-off-by: BruceLoveDecimal <liuqihao970610@gmail.com>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Observability: NVTX tracing + Prometheus metrics
Adds a two-layer observability stack for RL-Kernel.
NVTX tracing (micro) — rlk:: ranges around every C++ operator binding plus Python stage ranges (rlk::score, rlk::train_step, …), visible on an Nsight Systems timeline. Opt-in via RL_KERNEL_NVTX=1; off by default (cached branch, no cost).
Prometheus metrics (macro) — a per-process /metrics endpoint exposing token throughput, rollout QPS, stage latencies, backend/fallback state, KV-cache fragmentation, peak memory, and training loss, plus a ready-made Grafana dashboard. prometheus-client is an optional extra; without it every call is a silent no-op.
Notes
Instrumentation is exception-transparent and per-stage (never per-token). Measured overhead +0.9% on an RTX 5090.
Existing StageResult.metrics dicts are unchanged.
Verified on GPU: CUDA extension builds, full suite green (572 passed), nsys shows the rlk:: ranges, live /metrics served.
Closes #72