Skip to content

Fix DCA-derived IBIT zscore settings#143

Merged
Pigbibi merged 1 commit into
mainfrom
codex/fix-dca-derived-ibit-zscore-settings
Jul 2, 2026
Merged

Fix DCA-derived IBIT zscore settings#143
Pigbibi merged 1 commit into
mainfrom
codex/fix-dca-derived-ibit-zscore-settings

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Summary

  • remove the website IBIT Z-Score exit selector and legacy account sync setting
  • derive IBIT Z-Score runtime/plugin settings from ibit_smart_dca smart DCA mode
  • restrict DCA controls to IBIT and Nasdaq/S&P DCA strategies; BTC DCA no longer enables DCA settings

Validation

  • node tests/strategy_switch_worker_validation.mjs
  • python3 -m unittest python.tests.test_runtime_settings
  • python3 python/scripts/build_config.py --check
  • node/python syntax checks and git diff --check
  • local browser mock validation for IBIT smart DCA and BTC DCA disabled controls

Co-Authored-By: Codex <noreply@openai.com>
@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown

🤖 Codex PR Review

⚠️ Review skipped: The Codex review could not be completed.

No Codex service URL or API key configured. Set CODEX_AUDIT_SERVICE_URL, ANTHROPIC_API_KEY, or OPENAI_API_KEY.

Please ensure a human reviewer checks this PR before merging.

@Pigbibi Pigbibi merged commit cb6d9e1 into main Jul 2, 2026
8 checks passed
@Pigbibi Pigbibi deleted the codex/fix-dca-derived-ibit-zscore-settings branch July 2, 2026 17:32

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b2afbebe8b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

dca_controls = _extract_dca_control_fields(extra_variables)
ibit_zscore_exit_controls = _extract_ibit_zscore_exit_control_fields(extra_variables)
_extract_ibit_zscore_exit_control_fields(extra_variables)
effective_dca_mode = _effective_dca_mode(args, runtime_target["strategy_profile"], dca_controls)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Honor preserved smart DCA when deriving IBIT Z-score

When an IBIT account already has DCA_MODE=smart and the dispatch omits DCA controls (for example, a manual run that only changes reserved cash or execution mode), this defaults effective_dca_mode to fixed before reading/preserving the existing variable. Later _dca_extra_variables omits DCA_MODE, so _preserve_reserved_cash_fields keeps the old smart DCA value, but the plugin mounts, scheduler, and IBIT_ZSCORE_EXIT_* variables were generated for fixed mode, leaving a smart-DCA account with the z-score plugin disabled and the monthly scheduler. Derive this from the current/preserved DCA setting or require the DCA control whenever these derived settings are recomputed.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant