Skip to content

chore(deps): align QPK pin to f07f0bdeb658#322

Closed
Pigbibi wants to merge 1 commit into
mainfrom
auto/qpk-pin-sync-f07f0bdeb658
Closed

chore(deps): align QPK pin to f07f0bdeb658#322
Pigbibi wants to merge 1 commit into
mainfrom
auto/qpk-pin-sync-f07f0bdeb658

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Jul 10, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • 自动将 QPK pin 对齐到 f07f0bdeb658
  • 若仓库使用 uv.lock,同步刷新 lockfile

Test plan

  • Repo CI 转绿

🤖 Generated with Claude Code

Automated downstream QPK pin update after QPK_PIN landed on main.

Co-Authored-By: Claude <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown

🤖 Codex PR Review

Merge allowed: No issues found


Review by Codex PR Review bot • PR

@Pigbibi

Pigbibi commented Jul 10, 2026

Copy link
Copy Markdown
Collaborator Author

Superseded: QPK downstream sync is being corrected to update both supported qsl.toml pin layouts.

@Pigbibi Pigbibi closed this Jul 10, 2026
@Pigbibi
Pigbibi deleted the auto/qpk-pin-sync-f07f0bdeb658 branch July 10, 2026 16:17

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3bbda3fc3d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread pyproject.toml
"google-auth",
"longport==3.0.23",
"quant-platform-kit @ git+https://github.com/QuantStrategyLab/QuantPlatformKit.git@2381aa4577e9fd6329053a73a1c888929170eaf3",
"quant-platform-kit @ git+https://github.com/QuantStrategyLab/QuantPlatformKit.git@f07f0bdeb6580e1f28109830ccde85cb8ace092a",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep qsl metadata pin in sync

Changing the install pin here without updating qsl.toml leaves the repository metadata advertising the old QPK commit (2381aa...) while pyproject.toml installs f07f0.... This is already enforced by tests/test_qsl_metadata.py, which compares qsl.requires.quant_platform_kit with this dependency pin, so CI fails immediately and any metadata-driven bundle checks will see the wrong platform revision.

Useful? React with 👍 / 👎.

Comment thread pyproject.toml
"google-auth",
"longport==3.0.23",
"quant-platform-kit @ git+https://github.com/QuantStrategyLab/QuantPlatformKit.git@2381aa4577e9fd6329053a73a1c888929170eaf3",
"quant-platform-kit @ git+https://github.com/QuantStrategyLab/QuantPlatformKit.git@f07f0bdeb6580e1f28109830ccde85cb8ace092a",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Pin the dependency to QPK_PIN, not the QPK commit

The Check QPK pin consistency workflow reads external/QuantPlatformKit/QPK_PIN; that file is the compatibility SHA, not necessarily the QuantPlatformKit repo commit SHA (for example, at f07f0..., QPK_PIN contains f0d6bc...). Pinning this dependency to f07f0... therefore makes the blocking guard reject pyproject.toml/uv.lock even after the local metadata mismatch is fixed.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant