Skip to content

[codex] Promote US combo live dependency#302

Merged
Pigbibi merged 1 commit into
mainfrom
codex/promote-us-combo-live-pin
Jul 4, 2026
Merged

[codex] Promote US combo live dependency#302
Pigbibi merged 1 commit into
mainfrom
codex/promote-us-combo-live-pin

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Jul 4, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Update us-equity-strategies pin to the merged live-core us_equity_combo implementation.
  • Remove us_equity_combo_core from the IBKR live/selectable rollout expectations.
  • Add regression coverage that rejects the shadow profile as a direct runtime target.

Validation

  • PYTHONPATH=/Users/lisiyi/Projects/InteractiveBrokersPlatform:/Users/lisiyi/Projects/UsEquityStrategies/src:/Users/lisiyi/Projects/HkEquityStrategies/src:/Users/lisiyi/Projects/QuantPlatformKit/src python3 -m pytest tests/test_runtime_config_support.py -q
  • uv run pytest tests/test_runtime_config_support.py -q
  • uv lock --check
  • python3 -m py_compile runtime_config_support.py strategy_registry.py
  • git diff --check

Co-Authored-By: Codex <noreply@openai.com>
@cursor

cursor Bot commented Jul 4, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@Pigbibi Pigbibi merged commit c25624e into main Jul 4, 2026
2 checks passed
@Pigbibi Pigbibi deleted the codex/promote-us-combo-live-pin branch July 4, 2026 21:37

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8e2adc6bbb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread pyproject.toml
"yfinance",
"quant-platform-kit @ git+https://github.com/QuantStrategyLab/QuantPlatformKit.git@0063af3b4a974650ea58a7d3f26dd1b94f65d3e8",
"us-equity-strategies @ git+https://github.com/QuantStrategyLab/UsEquityStrategies.git@67e1ed69d7b9c318f94c8809121d2b9481d6b11a",
"us-equity-strategies @ git+https://github.com/QuantStrategyLab/UsEquityStrategies.git@1643f37d723c4d0fdc475ce1030b3d911c07aacb",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Add runtime handling for promoted combo inputs

With this dependency bump, us_equity_combo is now exposed as the live profile and the updated status coverage expects it to run as current_holdings+russell_snapshot, but LoadedStrategyRuntime.evaluate() still only dispatches feature snapshots, market_data, market_history, or portfolio+derived/benchmark inputs before raising Unsupported required_inputs for anything else. When operators select the newly promoted us_equity_combo target, it will be accepted by config/status but fail at signal computation unless the platform builds the Russell snapshot/current-holdings inputs or keeps the profile out of the live allowlist.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant