[codex] Support US core combo shadow profile#301
Conversation
Co-Authored-By: Codex <noreply@openai.com>
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5787f105b5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| assert "nasdaq_sp500_smart_dca" in by_profile | ||
| assert "ibit_smart_dca" in by_profile | ||
| assert by_profile["us_equity_combo_core"]["profile_group"] == "direct_runtime_inputs" | ||
| assert by_profile["us_equity_combo_core"]["input_mode"] == "current_holdings+russell_snapshot" |
There was a problem hiding this comment.
This enables us_equity_combo_core as an IBKR profile while the status now declares its input mode as current_holdings+russell_snapshot, but the live signal path in LoadedStrategyRuntime.evaluate only dispatches feature_snapshot, market_data, market_history, or portfolio_snapshot plus derived/benchmark inputs before raising ValueError("Unsupported required_inputs..."). In any Cloud Run/service target that selects this new profile, config loading and status checks can pass, but signal computation will fail because no runtime branch materializes russell_snapshot or handles this input combination; add that runtime path or keep the profile out of the enabled set until it exists.
Useful? React with 👍 / 👎.
Summary
us-equity-strategiesgit pin to the mergedus_equity_combo_coresupport commitus_equity_combo_coreValidation
PYTHONPATH=/Users/lisiyi/Projects/InteractiveBrokersPlatform:/Users/lisiyi/Projects/UsEquityStrategies/src:/Users/lisiyi/Projects/HkEquityStrategies/src:/Users/lisiyi/Projects/QuantPlatformKit/src python3 -m pytest /Users/lisiyi/Projects/InteractiveBrokersPlatform/tests/test_runtime_config_support.py -qpython3 -m py_compile ...uv lock --checkgit diff --checkNotes