Skip to content

chore: qsl runtime compatibility metadata#296

Merged
Pigbibi merged 2 commits into
mainfrom
codex/qsl-compat-runtime-v1
Jul 3, 2026
Merged

chore: qsl runtime compatibility metadata#296
Pigbibi merged 2 commits into
mainfrom
codex/qsl-compat-runtime-v1

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Jul 3, 2026

Copy link
Copy Markdown
Collaborator

Summary\n- Add qsl.toml metadata for compatibility runtime upgrade mode.\n- Add minimal metadata tests for runtime repos where applicable.\n- For Binance: keep requirements/pip stack and add migration TODO note.\n- For IBKRGatewayManager/SchwabTokenAutoRefresher: metadata-only for non-Python package tooling.

Co-Authored-By: Codex <noreply@openai.com>

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 392035d520

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread qsl.toml
Comment on lines +8 to +10
quant_platform_kit = "0063af3b4a974650ea58a7d3f26dd1b94f65d3e8"
us_equity_strategies = "46887bc3f5454d5b59623b1f5efb7c65912c6b8b"
hk_equity_strategies = "61993bf261aeccf64b5a75428b9405f4e1d1d682"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Guard QSL dependency pins against drift

These new qsl.requires SHAs duplicate the install pins in pyproject.toml, but the blocking CI guard only runs scripts/check_qpk_pin_consistency.py, whose PINNED_FILE_GLOBS at line 22 omits qsl.toml (the workflow invokes that guard at .github/workflows/ci.yml:113). When the normal dependency bump updates pyproject.toml/uv.lock, this metadata can silently stay on the old bundle and compatibility automation will consume stale pins; please add this file to the guard or make the test compare it to the actual dependency pins.

Useful? React with 👍 / 👎.

Co-Authored-By: Codex <noreply@openai.com>
@Pigbibi Pigbibi merged commit 5146d27 into main Jul 3, 2026
2 checks passed
@Pigbibi Pigbibi deleted the codex/qsl-compat-runtime-v1 branch July 3, 2026 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant