Skip to content

ci/security/test: automated audit fixes for HkEquityStrategies#60

Merged
Pigbibi merged 1 commit into
mainfrom
codex/audit-fix-20260702-1603
Jul 2, 2026
Merged

ci/security/test: automated audit fixes for HkEquityStrategies#60
Pigbibi merged 1 commit into
mainfrom
codex/audit-fix-20260702-1603

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Summary

  • redact secret-like findings in the Codex review gate instead of echoing matched values
  • add regression coverage for the redaction behavior
  • migrate deprecated Ruff top-level ignore settings
  • add pip check and package build to CI

Problems found

  • scripts/gate_codex_app_review.py reported matched secret-like fragments directly in violation messages
  • Ruff emitted a deprecation warning for top-level ignore
  • CI did not verify dependency health or package build

Fixes applied

  • normalize secret field names and emit <redacted> in gate findings
  • add tests/test_gate_codex_app_review.py
  • move ignore to [tool.ruff.lint]
  • add python -m pip check and python -m build to CI

Security impact

  • reduces risk of secret-like values leaking into CI logs or gate output
  • no runtime strategy behavior, credentials, or platform contracts changed

Architecture impact

  • low risk; audit gate output and CI verification only

Tests run

  • .venv-audit/bin/python -m pip check
  • .venv-audit/bin/ruff check .
  • .venv-audit/bin/python -m pytest -q tests/test_gate_codex_app_review.py
  • .venv-audit/bin/python -m pytest -q
  • .venv-audit/bin/python -m build
  • actionlint
  • git diff --check

Failed or skipped checks with reasons

  • none

Deployment notes

  • no deployment required

Rollback plan

  • revert commit 08a7a29

Manual follow-up checklist

  • confirm PR checks pass
  • merge after branch protection requirements are satisfied

@Pigbibi Pigbibi added codex AI Codex operations github_actions Pull requests that update GitHub Actions python Python ecosystem human-review-required Requires human review before merge labels Jul 2, 2026
@Pigbibi Pigbibi enabled auto-merge (squash) July 2, 2026 08:08
@Pigbibi Pigbibi merged commit 08e20a5 into main Jul 2, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

codex AI Codex operations github_actions Pull requests that update GitHub Actions human-review-required Requires human review before merge python Python ecosystem

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant