Skip to content

fix: align hk strategy ref with merged phase2 main#45

Merged
Pigbibi merged 1 commit into
mainfrom
codex/qsl-phase2-final-hk-strategy-ref
Jul 3, 2026
Merged

fix: align hk strategy ref with merged phase2 main#45
Pigbibi merged 1 commit into
mainfrom
codex/qsl-phase2-final-hk-strategy-ref

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Summary\n- update hk-equity-strategies pin to the merged phase-2 main commit\n- refresh uv.lock\n\n## Validation\n- uv lock\n- uv lock --check\n- uv run pytest tests/test_qsl_metadata.py -q\n- git diff --check

Co-Authored-By: Codex <noreply@openai.com>

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c8ad71b700

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread pyproject.toml
dependencies = [
"pandas>=2.0",
"hk-equity-strategies @ git+https://github.com/QuantStrategyLab/HkEquityStrategies.git@00dd0e5b62a6fa65bd9262e15c083468e8b8c191",
"hk-equity-strategies @ git+https://github.com/QuantStrategyLab/HkEquityStrategies.git@dbbefb688cd144837aa59581b1930a14c11411ad",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Restore the QSL-compatible strategy pin

When the QSL bundle gate checks transitive strategy-library metadata, this SHA rolls hk-equity-strategies back from 00dd0e5 to dbbefb6, which predates the qsl.toml compatibility metadata added by the previous pin. This repo has enforce_bundle = true in qsl.toml, so installs resolved from this dependency will no longer expose the strategy library's compat bundle metadata and can fail the enforced bundle contract. Please pin a post-00dd0e5 main SHA that still includes that metadata.

Useful? React with 👍 / 👎.

@Pigbibi Pigbibi merged commit 4b79c87 into main Jul 3, 2026
4 checks passed
@Pigbibi Pigbibi deleted the codex/qsl-phase2-final-hk-strategy-ref branch July 3, 2026 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant