Skip to content

[codex] simplify compact notifications and update dashboard pin#184

Merged
Pigbibi merged 1 commit into
mainfrom
codex/simplify-compact-notifications-and-update-dashboard-pin
Jul 1, 2026
Merged

[codex] simplify compact notifications and update dashboard pin#184
Pigbibi merged 1 commit into
mainfrom
codex/simplify-compact-notifications-and-update-dashboard-pin

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Simplify Telegram compact notifications to account/positions/trade outcome only.
  • Fix margin-enabled dashboard wording so buying power is not described as cash-only assets.
  • Bump UsEquityStrategies pin to the merged dashboard fix.

Test Plan

  • See repository-specific pytest commands in the PR checks and local validation.

@Pigbibi Pigbibi enabled auto-merge (squash) July 1, 2026 21:02
@Pigbibi Pigbibi merged commit 7b0400f into main Jul 1, 2026
2 checks passed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 93123ae3ca

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread notifications/telegram.py
@@ -353,6 +354,7 @@ def format_small_account_whole_share_bootstrap_notes(
"account_overview_title": "📌 Strategy Account",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Avoid labeling buying-power totals as net liquidation

When margin mode is enabled, FirstradeBrokerAdapters._resolve_total_equity returns buying_power + position_market_value before falling back to the broker's account total, and run_strategy_cycle passes managed symbols so that branch is used for strategy portfolios. For margin accounts where buying power includes loan capacity, the value rendered here is therefore not net liquidation, so the new label can make users read a levered purchasing-power figure as account equity. Please either feed an actual net-liquidation/account-value field into this label or keep the wording aligned with the underlying buying-power-plus-positions value.

Useful? React with 👍 / 👎.

@Pigbibi Pigbibi deleted the codex/simplify-compact-notifications-and-update-dashboard-pin branch July 1, 2026 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant