[codex] simplify compact notifications and update dashboard pin#184
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 93123ae3ca
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -353,6 +354,7 @@ def format_small_account_whole_share_bootstrap_notes( | |||
| "account_overview_title": "📌 Strategy Account", | |||
There was a problem hiding this comment.
Avoid labeling buying-power totals as net liquidation
When margin mode is enabled, FirstradeBrokerAdapters._resolve_total_equity returns buying_power + position_market_value before falling back to the broker's account total, and run_strategy_cycle passes managed symbols so that branch is used for strategy portfolios. For margin accounts where buying power includes loan capacity, the value rendered here is therefore not net liquidation, so the new label can make users read a levered purchasing-power figure as account equity. Please either feed an actual net-liquidation/account-value field into this label or keep the wording aligned with the underlying buying-power-plus-positions value.
Useful? React with 👍 / 👎.
Summary
Test Plan