Filter runtime guard logs by ready revision#180
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7440e23196
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| f'AND resource.labels.service_name="{service}" ' | ||
| f'AND timestamp >= "{since_text}"' | ||
| f'AND timestamp >= "{service_since_text}"' |
There was a problem hiding this comment.
Add the ready revision to the log filter
When a Cloud Run service has split traffic or an older revision finishes requests after a new revision becomes ready, this query still reads every revision because it only filters by service_name and timestamp. The repo already treats non-latest traffic revisions as a supported state in .github/workflows/sync-cloud-run-env.yml:809-816, so old-revision failures after latestReadyRevisionName was created can still page the runtime guard; include resource.labels.revision_name for the resolved ready revision if the guard is meant to isolate the ready revision's logs.
Useful? React with 👍 / 👎.
Summary
Validation