Update QC Branch#47
Merged
Martin-Molinero merged 0 commit intoQuantConnect:masterfrom Mar 9, 2021
C-SELLERS:refactor-qc-pythonnet3
Merged
Update QC Branch#47Martin-Molinero merged 0 commit intoQuantConnect:masterfrom C-SELLERS:refactor-qc-pythonnet3
Martin-Molinero merged 0 commit intoQuantConnect:masterfrom
C-SELLERS:refactor-qc-pythonnet3
Conversation
4 tasks
This was referenced Feb 26, 2021
Closed
This was referenced Mar 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
Get QC PythonNet up to date with root repo.
Related to QuantConnect/Lean#452
To do this I needed to reflect a lot of our custom changes onto the root repo in order to keep QuantConnect functionality as desired.
QuantConnect Changes Reflected onto Root repo:
Patches to address failures in Lean:
PyNumber_Longbut still keeps the use ofRuntime.PyLong_AsSignedSize_tto finish the conversion. The bug that discovered this was trying to convert a Python float to int, this used to work but was failing until this refactor. Reference the added test in bd94e49. ( d87584b )Tests added:
Some tests had to be adjusted for behavior changes caused by our commits. I have adjusted enough to have all PythonNet embedded tests passing, but there are still some issues with PyTests that need to be addressed/resolved.