Issue #565 passing "env" to docker as extra-docker-config

[mrcghil]

No description provided.

[jaredbroad]

👍

[Martin-Molinero]

Hey @mrcghil, thanks for the contribution!

Believe the extra environment values should merge with any existing in the run_options collection, you can follow the pattern of volumes a few lines below for example.

[mrcghil]

@Martin-Molinero Good point. I will append instead of overwriting. Are you okay with me ingesting a list of tuples - or iterables in general - of the kind ("env_var_name", "env_var_value") or would you rather pass a list of strings directly? The Tuple solution was working well enough for me, but I realise it might be less straightforward for others.

[Martin-Molinero]

@Martin-Molinero Good point. I will append instead of overwriting. Are you okay with me ingesting a list of tuples - or iterables in general - of the kind ("env_var_name", "env_var_value") or would you rather pass a list of strings directly? The Tuple solution was working well enough for me, but I realise it might be less straightforward for others.

Hey! I would suggest accepting also a list/iterables of env_name=value strings, mimicking the docker run --env VAR1=value1 --env VAR2=value2. You could support ur current version too if u don't detect = was provided in the string 👍

[mrcghil]

Hello!
Apologies for the long pause. I have updated the file to support inputs as dict, and lists containing tuples or strings formatted as "key=value".

[jhonabreul]

Thank you for your contribution!