Skip to content

Check if Python OnMarginCall is defined#3733

Merged
jaredbroad merged 1 commit intoQuantConnect:masterfrom
Martin-Molinero:bug-3732-python-onmargincall
Oct 16, 2019
Merged

Check if Python OnMarginCall is defined#3733
jaredbroad merged 1 commit intoQuantConnect:masterfrom
Martin-Molinero:bug-3732-python-onmargincall

Conversation

@Martin-Molinero
Copy link
Member

Description

  • Will check if python OnMarginCall is defined and throws if returns null
    or empty list
  • Adding unit tests

Related Issue

Closes #3732

Motivation and Context

Fix exception being thrown

Requires Documentation Change

N/A

How Has This Been Tested?

Unit and regression tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Non-functional change (xml comments/documentation/etc)

Checklist:

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>

- Will check if python OnMarginCall is defined and throw is returns null
or empty list
- Adding unit tests
@jaredbroad jaredbroad merged commit a6ad56b into QuantConnect:master Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Python OnMarginCall throws exception

2 participants