Skip to content

Python Jupyter lab improvements#3563

Merged
jaredbroad merged 5 commits intomasterfrom
bug-2402-python-jupiter
Sep 6, 2019
Merged

Python Jupyter lab improvements#3563
jaredbroad merged 5 commits intomasterfrom
bug-2402-python-jupiter

Conversation

@Martin-Molinero
Copy link
Member

@Martin-Molinero Martin-Molinero commented Sep 5, 2019

Description

  • Python Jupyter lab will not require setting up/compiling pythonnet
    • For macOS and Linux will require an extra copy operation due to the need to have two different Python.Runtime.dll binaries for Lean and Jupyter
  • Fix for macOS Algorithm.History requests, thanks @AlexCatarino !
  • PythonNet 1.0.5.23 adds initialization logs, related to https://github.com/QuantConnect/Lean/issues/3476
  • Updating DockerfileJupyter

Requires QuantConnect/pythonnet#34

Related Issue

Closes #2402, closes #3559

Motivation and Context

Improve user experience using Jupyter lab

Requires Documentation Change

Readme is being updated

How Has This Been Tested?

  • Unit and regression tests
  • Jupyter lab in linux, mac and windows
  • Lean python sanity tested mac and linux (HistoryAlgorithm/BasicTemplateFrameworkAlgorithm/CustomDataBitcoinAlgorithm)
  • Built and ran DockerfileJupyter
  • Cloud python sanity tested branch (HistoryAlgorithm/BasicTemplateAlgorithm/CustomDataBitcoinAlgorithm)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Non-functional change (xml comments/documentation/etc)

Checklist:

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>

@Martin-Molinero Martin-Molinero force-pushed the bug-2402-python-jupiter branch 5 times, most recently from 68240fa to 45028da Compare September 6, 2019 02:48
Martin-Molinero and others added 4 commits September 5, 2019 23:55
Following the convert python objects patter, it replaces `QCAlgorithm.GetSymbolsFromPyObject`.
Add unit tests.
@jaredbroad jaredbroad merged commit a08c366 into master Sep 6, 2019
@Martin-Molinero Martin-Molinero deleted the bug-2402-python-jupiter branch September 10, 2019 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

kernel dies unexpectedly inside research notebook Error No module named 'clr' when trying Lean's Jupiter support

3 participants