Skip to content

Comments

feat: not logging warnings when offline#729

Merged
2ndalpha merged 6 commits intomasterfrom
siim/offlinelogging
Aug 19, 2024
Merged

feat: not logging warnings when offline#729
2ndalpha merged 6 commits intomasterfrom
siim/offlinelogging

Conversation

@2ndalpha
Copy link
Member

Reducing noise when browser is offline.
This PR does not change any functionality - only logging.

Related issues

Checklist

  • Code is covered with tests.

@codecov-commenter
Copy link

codecov-commenter commented Aug 19, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 55.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 81.62%. Comparing base (2cf2f98) to head (1134eb5).
Report is 2 commits behind head on master.

Files Patch % Lines
src/lib/services/graphql/graphql.service.ts 55.00% 9 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #729      +/-   ##
==========================================
- Coverage   82.31%   81.62%   -0.70%     
==========================================
  Files          23       23              
  Lines         786      800      +14     
  Branches      140      143       +3     
==========================================
+ Hits          647      653       +6     
- Misses        130      146      +16     
+ Partials        9        1       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@2ndalpha 2ndalpha requested a review from KarlMae August 19, 2024 11:54
@2ndalpha 2ndalpha added this pull request to the merge queue Aug 19, 2024
Merged via the queue into master with commit dedb5ca Aug 19, 2024
@2ndalpha 2ndalpha deleted the siim/offlinelogging branch August 19, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants