Issue #67: Target encoding for linear regression MVP#84
Merged
Conversation
added 4 commits
August 6, 2021 09:32
…ession: mainly docstring modifications, but verified the approach, it will work for regression without changes.
…ing when weight=0.
…ing when weight=0. (part 2, fixing an oopsie.)
3 tasks
sborms
approved these changes
Aug 6, 2021
Contributor
sborms
left a comment
There was a problem hiding this comment.
Nice, well done! Very thorough testing 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Story Title
Issue #67: Target encoding for linear regression MVP
Changes made
How does the solution address the problem
This PR will provide a target encoding MVP for linear regression.
Linked issues
Resolves #67.