Skip to content

AUC sorting inconsistency #28

@JanBenisek

Description

@JanBenisek

We found a small inconsistency - in plot_univariate_predictor_quality() we sort by 'AUC train'

df = (df_auc[df_auc["preselection"]]
.sort_values(by='AUC train', ascending=False))

while in compute_univariate_preselection() we sort by 'AUC selection'.

return (df_auc.sort_values(by='AUC selection', ascending=False)
.reset_index(drop=True))

It does not ahve any effect on the modeling, but then the plot and preselected_predictors have different order of variables, which is confusing.

Both should be sorted by 'AUC selection'.

Metadata

Metadata

Assignees

Labels

bugSomething isn't workinggood first issueGood for newcomers

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions