Nonant name validation#339
Closed
bknueven wants to merge 5 commits intoPyomo:mainfrom
Closed
Conversation
4bf7df5 to
deb66a6
Compare
bknueven
commented
Nov 2, 2023
Collaborator
Author
bknueven
left a comment
There was a problem hiding this comment.
Maybe we can use this module to avoid some unnecessary copying:
DLWoodruff
added a commit
to DLWoodruff/mpi-sppy-1
that referenced
this pull request
Mar 16, 2026
Verify that nonant variable names match (same order) across all scenarios, catching a common bug where scenario creators provide variables in inconsistent order. Uses hashlib for cross-rank comparison via MPI allreduce. Adds --turn-off-names-check option (auto-disabled for proper bundles). Includes bad_farmer test example. Resurrects the idea from PR Pyomo#339 with a fresh implementation. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
3 tasks
DLWoodruff
added a commit
that referenced
this pull request
Mar 17, 2026
* Add nonant variable name validation across scenarios Verify that nonant variable names match (same order) across all scenarios, catching a common bug where scenario creators provide variables in inconsistent order. Uses hashlib for cross-rank comparison via MPI allreduce. Adds --turn-off-names-check option (auto-disabled for proper bundles). Includes bad_farmer test example. Resurrects the idea from PR #339 with a fresh implementation. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * Document --turn-off-names-check in generic_cylinders.rst Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * Fix ruff: remove unused import and variable in test Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * Update generic_cylinders.rst * Fix nonant name validation for ADMM, bundles, and no-MPI - Use MPI.INT (not MPI.LONG) for cross-rank hash check, fixing the no-mpi4py mock MPI stub - Auto-disable names check when scenarios_per_bundle is set (proper bundles create scenarios with different name prefixes) - Disable names check in ADMM cylinder scripts (ADMM wrapping creates scenarios with different variable naming conventions) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Collaborator
|
PR#634 provided this functionality |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODOs:
See how expensive this check isglobal_tocon entry and exitProduce a better error when the reduction check fails