feat(build_mp): esp32 displayif PSRAM preflight check#11
Draft
bdbarnett wants to merge 1 commit into
Draft
Conversation
Warn before esp32 builds when displayif is present but CONFIG_SPIRAM is not enabled on S3/P4 boards. Supports interactive continue, non-interactive bypass via DISPLAYIF_SKIP_SPIRAM_CHECK=1. Co-authored-by: bbarnett <bbarnett@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
esp32_displayif_preflight()tobuild_mp.sh, called before esp32 builds whendisplayif/is present in the workspace.CONFIG_SPIRAMis not enabled on S3/P4 boards (needed forrgbframebuffer/mipidsilarge framebuffers)DISPLAYIF_SKIP_SPIRAM_CHECK=1Not included (optional follow-up)
Automatic sdkconfig patching to enable SPIRAM in board defaults — preflight warning only for now.
Test plan
./build_mp.sh --port esp32 --board ESP32_GENERIC_S3with displayif present, no SPIRAM → warningDISPLAYIF_SKIP_SPIRAM_CHECK=1→ silent