Hacking Facebook lecture TWP45#102
Merged
NicolasSandoval merged 2 commits intoPyAr:masterfrom Jun 25, 2021
Merged
Conversation
|
Published to http://pyar.github.io/PyZombis/102/index.html |
LeoCumpli21
approved these changes
Jun 17, 2021
Collaborator
LeoCumpli21
left a comment
There was a problem hiding this comment.
Wow! It is amazing. With this implemented we can begin to explore the lectures that currently don't work. Well done :)
y-martinez
approved these changes
Jun 17, 2021
Collaborator
y-martinez
left a comment
There was a problem hiding this comment.
Nice! it works like a charm. Like I said before, maybe will be great to change the name the lecture to another one :)
Collaborator
Author
Yes, I think in the future when more exercises are added to this lecture, we can change its name :) |
Devilish19
approved these changes
Jun 19, 2021
NicolasSandoval
approved these changes
Jun 25, 2021
Member
NicolasSandoval
left a comment
There was a problem hiding this comment.
This is a marvelous work, congrats!
This was referenced Jun 29, 2021
Closed
reingart
pushed a commit
that referenced
this pull request
Oct 27, 2021
…ercise Hacking Facebook lecture TWP45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR closes AngelaRemolina#8 :
requirements.txtfile is changed to load the customized Runestone version.To do the runestone component the following steps were followed:
activecode_brython.jswas created with a html template that loads the Brython and attach the code to it: Add the html elements as a template needed for Brython AngelaRemolina/RunestoneComponents#4python3_interpreteras an activecode option: Python3_interpreter activecode directive AngelaRemolina/RunestoneComponents#5print()and errors is being built: Console displaying errors and prints in a <pre> tag AngelaRemolina/RunestoneComponents#11This PR also resolves AngelaRemolina#7 with a playwright test that checks the image is displayed correctly.
Note: Exercises that did not work due to access to the Facebook API have been removed. More exercises still need to be implemented in this lecture on the future.
Checklist
Note: Only the iframe locator is with XPath. I wasn't able to locate it other way but I'm sure that XPath won't change because of the runestone template for activecode blocks. If you have any suggestion I'd be happy to implement them :)
Screenshots
test_l45_1_chromium.mp4