This repository was archived by the owner on May 24, 2026. It is now read-only.
fix: address review findings round 3 (PR #806)#809
Closed
github-actions[bot] wants to merge 2 commits into
Closed
Conversation
…bleAllHooks) in Settings UI Add an Advanced section to the Settings page with toggles for three Copilot CLI configuration options: - **Compact Paste**: collapse large pasted content to save context tokens - **Respect .gitignore**: exclude gitignored files from working-tree context - **Disable All Hooks**: globally disable all CLI hooks Implementation: - Add CompactPaste, RespectGitignore, DisableAllHooks bool properties to ConnectionSettings with JSON round-trip support - Add SyncCliConfig() method that merges these values into ~/.copilot/config.json (preserving existing keys) - Register three new SettingDescriptors under 'Advanced' category in SettingsRegistry (hidden in Remote/Demo modes) - Add Advanced nav item, section heading, and SettingEditor rendering in Settings.razor - Wire OnSettingChanged to call SyncCliConfig() for advanced.* settings - Add unit tests: defaults, round-trip, backward compat, SyncCliConfig write + merge, registry get/set/visibility/search - Add integration test for Advanced section rendering Fixes #698 Co-authored-by: copilot-agentic-workflow[bot] <224017+copilot-agentic-workflow[bot]@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Fix Advanced nav button visible in Remote/Demo modes (Finding 1) - Add ImportCliConfigValues() for startup sync from config.json (Finding 2 & 4) - Abort SyncCliConfig on corrupt config.json to prevent data loss (Finding 3) - Add assertions to integration tests (Finding 5) - Use atomic temp-file-then-rename for config writes (Finding 6) - Add 6 new unit tests for import, corrupt-abort, and atomic write Co-authored-by: copilot-agentic-workflow[bot] <224017+copilot-agentic-workflow[bot]@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Owner
|
Stale fix-round PR — fixes were pushed to the main PR branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses all review findings from expert review rounds on PR #806.
Fixes applied:
ImportCliConfigValues()called at Settings page load to sync from~/.copilot/config.jsonconfig.jsonnow aborts sync instead of silently dropping unrelated CLI keysconfig.jsonedits preserved via import-before-write patternAssert.True,Assert.Contains)Tests
Warning
The following domain was blocked by the firewall during workflow execution:
192.0.2.1To allow these domains, add them to the
network.allowedlist in your workflow frontmatter:See Network Configuration for more information.