This repository was archived by the owner on May 24, 2026. It is now read-only.
fix: address review findings round 2 (PR #806)#808
Closed
github-actions[bot] wants to merge 5 commits into
Closed
Conversation
…bleAllHooks) in Settings UI Add an Advanced section to the Settings page with toggles for three Copilot CLI configuration options: - **Compact Paste**: collapse large pasted content to save context tokens - **Respect .gitignore**: exclude gitignored files from working-tree context - **Disable All Hooks**: globally disable all CLI hooks Implementation: - Add CompactPaste, RespectGitignore, DisableAllHooks bool properties to ConnectionSettings with JSON round-trip support - Add SyncCliConfig() method that merges these values into ~/.copilot/config.json (preserving existing keys) - Register three new SettingDescriptors under 'Advanced' category in SettingsRegistry (hidden in Remote/Demo modes) - Add Advanced nav item, section heading, and SettingEditor rendering in Settings.razor - Wire OnSettingChanged to call SyncCliConfig() for advanced.* settings - Add unit tests: defaults, round-trip, backward compat, SyncCliConfig write + merge, registry get/set/visibility/search - Add integration test for Advanced section rendering Fixes #698 Co-authored-by: copilot-agentic-workflow[bot] <224017+copilot-agentic-workflow[bot]@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The Advanced nav button was visible in Remote/Demo modes even though the corresponding section was empty (settings hidden by mode check). Wrap the button with the same mode guard used by the registry. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Return early on JSON parse failure instead of overwriting config.json with only PolyPilot keys (prevents silent data loss of unrelated CLI config) - Add ImportCliConfigValues() to read config.json values at startup so PolyPilot picks up manual CLI edits - Use temp-file-then-rename pattern for atomic writes (prevents torn reads) - Extract GetCopilotConfigDir() helper to reduce duplication Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Integration tests were logging results but never asserting, so they always passed. Add Assert.True/Assert.Contains for section visibility and content verification. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…ConfigValues - SyncCliConfig_AbortsOnCorruptFile: verifies file unchanged on parse failure - SyncCliConfig_AtomicWrite_UsesRename: verifies temp file cleanup - ImportCliConfigValues_ImportsFromConfigJson: verifies import from config.json - ImportCliConfigValues_IgnoresCorruptFile: verifies graceful handling - ImportCliConfigValues_NoFileNoCrash: verifies missing file handling Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Owner
|
Stale fix-round PR — fixes were pushed to the main PR branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses 5 review findings from expert review round 2 on PR #806.
Findings addressed
SyncCliConfig()never called at startup — config driftsImportCliConfigValues()that reads config.json at Settings page loadImportCliConfigValues()imports existing config.json values before any writeAdditional improvements
GetCopilotConfigDir()helper to reduce duplicationTests
✅ All 3666 tests pass (5 new tests added)
Warning
The following domain was blocked by the firewall during workflow execution:
192.0.2.1To allow these domains, add them to the
network.allowedlist in your workflow frontmatter:See Network Configuration for more information.