This repository was archived by the owner on May 24, 2026. It is now read-only.
fix: address expert review findings round 1 (PR #806)#807
Closed
github-actions[bot] wants to merge 7 commits into
Closed
fix: address expert review findings round 1 (PR #806)#807github-actions[bot] wants to merge 7 commits into
github-actions[bot] wants to merge 7 commits into
Conversation
…bleAllHooks) in Settings UI Add an Advanced section to the Settings page with toggles for three Copilot CLI configuration options: - **Compact Paste**: collapse large pasted content to save context tokens - **Respect .gitignore**: exclude gitignored files from working-tree context - **Disable All Hooks**: globally disable all CLI hooks Implementation: - Add CompactPaste, RespectGitignore, DisableAllHooks bool properties to ConnectionSettings with JSON round-trip support - Add SyncCliConfig() method that merges these values into ~/.copilot/config.json (preserving existing keys) - Register three new SettingDescriptors under 'Advanced' category in SettingsRegistry (hidden in Remote/Demo modes) - Add Advanced nav item, section heading, and SettingEditor rendering in Settings.razor - Wire OnSettingChanged to call SyncCliConfig() for advanced.* settings - Add unit tests: defaults, round-trip, backward compat, SyncCliConfig write + merge, registry get/set/visibility/search - Add integration test for Advanced section rendering Fixes #698 Co-authored-by: copilot-agentic-workflow[bot] <224017+copilot-agentic-workflow[bot]@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The Advanced nav button was visible in Remote/Demo modes even though the Advanced section itself was hidden (settings have IsVisible guards that exclude Remote/Demo). This left a nav button pointing to nothing. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
SyncCliConfig() was only called when a toggle changed, so if config.json was externally deleted or modified, PolyPilot's values would drift until the user toggled a setting. Now syncs on OnInitialized() as well. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
When config.json was malformed, the catch block silently swallowed the error and the method proceeded to overwrite the file with only the 3 PolyPilot keys — dropping all other CLI configuration. Now returns early on parse failure to preserve the existing file contents. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The integration tests logged results via Output.WriteLine but never called Assert, so they always passed regardless of actual behavior. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Replace File.WriteAllBytes with write-to-temp + File.Move(overwrite) pattern so concurrent readers never see a partially-written file. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Verifies that when config.json contains malformed JSON, SyncCliConfig returns early and preserves the original file instead of overwriting it with only PolyPilot keys. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Owner
|
Stale fix-round PR — fixes were pushed to the main PR branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses 5 of 6 expert review findings from round 1 on PR #806.
Findings addressed
settings.Modeguard matching the section'sIsVisibleSyncCliConfig()only called on toggle change — config driftsSyncCliConfig()onOnInitialized()in non-Remote/Demo modesAssert.True()callsFile.WriteAllBytesrisks torn readsFile.Move(overwrite)Finding skipped
~/.copilot/default pathSyncCliConfigalready acceptscopilotConfigDirparam; tests use temp dirs. Speculative concern per disputed findings evaluation.Tests
All 3662 tests pass including new test for parse-failure abort behavior.
Warning
The following domain was blocked by the firewall during workflow execution:
192.0.2.1To allow these domains, add them to the
network.allowedlist in your workflow frontmatter:See Network Configuration for more information.